Skip to content

Team members table with sorting, pagination and filtering.#124

Draft
jacobo-dominguez-wgu wants to merge 20 commits intoopenedx:masterfrom
WGU-Open-edX:team-members-table
Draft

Team members table with sorting, pagination and filtering.#124
jacobo-dominguez-wgu wants to merge 20 commits intoopenedx:masterfrom
WGU-Open-edX:team-members-table

Conversation

@jacobo-dominguez-wgu
Copy link
Copy Markdown
Contributor

@jacobo-dominguez-wgu jacobo-dominguez-wgu commented Mar 30, 2026

Description

Creating the team members table with new columns with filtering, sorting with pagination.

It closes #79
and all of its subissues: #81, #82, #83, #84

Includes code from #107

Pending things:

  • Unit testing.
  • Integration with API when is ready.
  • A couple of TODOs.
  • Change row background color for django roles.

Warning

Will be on draft status until the required endpoints are completed.
This PR requires some the endpoints proposed in the section "Proposed Endpoint for M2"

image image

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Mar 30, 2026
@openedx-webhooks
Copy link
Copy Markdown

Thanks for the pull request, @jacobo-dominguez-wgu!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Update the status of your PR

Your PR is currently marked as a draft. After completing the steps above, update its status by clicking "Ready for Review", or removing "WIP" from the title, as appropriate.


Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@bmtcril
Copy link
Copy Markdown
Contributor

bmtcril commented Mar 31, 2026

Sorry I haven't been following the frontend closely, just a question about the system scoped roles. Are these just users who have explicitly been given permissions in the given course/library, or would it include everyone with Staff / Superuser? I'm just concerned about it since very large instances could have dozens of those users and easily overwhelm the useful information.

@jacobo-dominguez-wgu
Copy link
Copy Markdown
Contributor Author

Sorry I haven't been following the frontend closely, just a question about the system scoped roles. Are these just users who have explicitly been given permissions in the given course/library, or would it include everyone with Staff / Superuser? I'm just concerned about it since very large instances could have dozens of those users and easily overwhelm the useful information.

In my understanding system roles like Global Staff and Super Admin are shown with global access to all scopes and all organization like this (one row per user):
image
So in case of having dozens of these it may overwhelm the useful information as you mention, but the filters can be useful to prevent this situation.
Correct me if I am wrong @gviedma-aulasneo, @rodmgwgu

@gviedma-aulasneo
Copy link
Copy Markdown

Sorry I haven't been following the frontend closely, just a question about the system scoped roles. Are these just users who have explicitly been given permissions in the given course/library, or would it include everyone with Staff / Superuser? I'm just concerned about it since very large instances could have dozens of those users and easily overwhelm the useful information.

In my understanding system roles like Global Staff and Super Admin are shown with global access to all scopes and all organization like this (one row per user): image So in case of having dozens of these it may overwhelm the useful information as you mention, but the filters can be useful to prevent this situation. Correct me if I am wrong @gviedma-aulasneo, @rodmgwgu

Yes, we are working on the assumption that the filter will be enough to solve this problem. We are developing under the assumption that large and complex instances are less common than their counterparts; we may change the approach if we get stronger feedback for the next iteration.

@mphilbrick211 mphilbrick211 added the mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). label Apr 1, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Apr 1, 2026
@bmtcril
Copy link
Copy Markdown
Contributor

bmtcril commented Apr 2, 2026

@gviedma-aulasneo would it be worth considering making the system users filtered by default since (I assume) there is no action that can be taken on them?

@gviedma-aulasneo
Copy link
Copy Markdown

@gviedma-aulasneo would it be worth considering making the system users filtered by default since (I assume) there is no action that can be taken on them?

We can discuss it, of course. The main reason they are listed here is transparency around who has access to the courses and libraries. I will add, only as context, that we even discussed whether this should be visible only to course/library admins and that there was also some discussion about placing them in a separate tab.

It seems less likely that we would change the designs for Verawood, and forcing this now would likely result in a poor UI. The current UI responds to filters by showing that they are applied, so using a default filter here would look a bit hacky. In practice, this would mean having a default view with all non-superuser roles selected as filters from the start, which does not seem like the best approach right now.

The designs for Willow are still being refined. A new way of grouping the list entries by user will help declutter the current view and make it easier to read. Unless you consider this to be something we should give more thought to, we can discuss showing superadmins in a separate list there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). mao-onboarding Reviewing this will help onboard devs from an Axim mission-aligned organization (MAO). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Waiting on Author

Development

Successfully merging this pull request may close these issues.

Task - RBAC AuthZ - US: M2.4 Team Members tab

6 participants